Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom serializer for avro raw format #1860

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Conversation

ERROH
Copy link

@ERROH ERROH commented Jul 12, 2024

This PR partially implements #1077.

It allows the encoding of Avro raw binary format, with a mapping configuration, for example:

      akhq:
          connections:
            my-cluster:
              serialization:
                avro-raw:
                  schemas-folder: "/app/avro_schemas"
                  topics-mapping:
                    - topic-regex: "data.*"
                      value-schema-file: "Schema.avsc"

see also #843

@ERROH ERROH marked this pull request as ready for review July 12, 2024 22:53
@ERROH
Copy link
Author

ERROH commented Aug 15, 2024

Hi, @AlexisSouquiere @tchiotludo, if you find the time could you have a look at this PR, thanks a lot.

@AlexisSouquiere AlexisSouquiere self-assigned this Sep 2, 2024
@AlexisSouquiere
Copy link
Collaborator

Hi @ERROH. I will review it this week

@AlexisSouquiere
Copy link
Collaborator

The PR looks good to me. I tried it and it works fine.
I have just one concern. Don't you think that we should group 'serialization' and 'deserialization' in single 'serdes' (or another name) to avoid duplicating the same configuration ?

From

      serialization:
        avro-raw:
          schemas-folder: "./schemas"
          topics-mapping:
            - topic-regex: "avro.*"
              value-schema-file: "avroSchema.avsc"
      deserialization:
        avro-raw:
          schemas-folder: "./schemas"
          topics-mapping:
            - topic-regex: "avro.*"
              value-schema-file: "avroSchema.avsc"

To

      serdes:
        avro-raw:
          schemas-folder: "./schemas"
          topics-mapping:
            - topic-regex: "avro.*"
              value-schema-file: "avroSchema.avsc"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants